Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix get bytes from LinkHashMap #5622

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

Fix get bytes size from LinkHashMap will throw exception at now.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test.

Check list

@@ -255,6 +255,7 @@ private int getBytesForValue(Object v) {
case "Double[]":
return ((Double[]) v).length * 8;
case "HashMap":
case "LinkedHashMap":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will other types of map be used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the data circulated within SeaTunnelRow. We should standardize the type used when creating map type data in SeaTunnelRow to prevent burden on downstream parsing. For now, Hashmap and LinkHashMap are enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@EricJoy2048 EricJoy2048 merged commit b1d66c5 into apache:dev Oct 13, 2023
7 of 8 checks passed
@Hisoka-X Hisoka-X deleted the fix-bytes-with-linkmap branch October 16, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants