[Feature] Support configure tableIdentifier for schema #5628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
force-pushed
the
dev_wenjun_addTableInSchema
branch
from
ba64f72
to
3c56bc2
Compare
ruanwenjun
force-pushed
the
dev_wenjun_addTableInSchema
branch
from
3c56bc2
to
5fb8b01
Compare
ruanwenjun
changed the title
hailin0
reviewed
Oct 16, 2023
docs/en/concept/schema-feature.md
Outdated
| @@ -24,6 +26,14 @@ schema = { | |||
| } | |||
| ``` | |||
|
|
|||
| ### table | |||
|
|
|||
| The table full name of the table identifier which the schema belongs to, it contains database, schema, table name. e.g. `database.schema.table`, `database.table`. | |||
There was a problem hiding this comment.
Suggested change
| The table full name of the table identifier which the schema belongs to, it contains database, schema, table name. e.g. `database.schema.table`, `database.table`. | |
| The table full name of the table identifier which the schema belongs to, it contains database, schema, table name. e.g. `database.schema.table`, `database.table`, `schema.table`. |
There was a problem hiding this comment.
We cannot support schema.table yet.
Since if user write a.b, we cannot know whather the given a is schema or database. And the logic is same with current code in TablePath::of(String fullName), the database and table is mandatory but schema is chooseable.
There was a problem hiding this comment.
You can consider integrating this scenario in the future
There was a problem hiding this comment.
I update this PR, we can support config schema.table and table in config.
ruanwenjun
force-pushed
the
dev_wenjun_addTableInSchema
branch
from
5fb8b01
to
bff7686
Compare
ruanwenjun
changed the title
hailin0
previously approved these changes
Oct 16, 2023
Hisoka-X
reviewed
Oct 17, 2023
docs/en/concept/schema-feature.md
Outdated
|
|
||
| Default is false. | ||
|
|
||
| If the schemaFirst is true, the schema will be used first, this means if we set `table = "a.b"`, a will be parsed as schema rather than database, then we can support write `table = "schema.table"`. |
There was a problem hiding this comment.
Suggested change
| If the schemaFirst is true, the schema will be used first, this means if we set `table = "a.b"`, a will be parsed as schema rather than database, then we can support write `table = "schema.table"`. | |
| If the schema_first is true, the schema will be used first, this means if we set `table = "a.b"`, `a` will be parsed as schema rather than database, then we can support write `table = "schema.table"`. |
docs/en/concept/schema-feature.md
Outdated
|
|
||
| The table full name of the table identifier which the schema belongs to, it contains database, schema, table name. e.g. `database.schema.table`, `database.table`, `table`. | ||
|
|
||
| ### schemaFirst |
There was a problem hiding this comment.
For same config style.
Suggested change
| ### schemaFirst | |
| ### schema_first |
| @@ -28,6 +28,27 @@ | |||
|
|
|||
| public class TableSchemaOptions { | |||
|
|
|||
| public static class TableIdentifierOptions { | |||
|
|
|||
| public static final Option<Boolean> SCHEMA_FIRST = | |||
|
good job. |
ruanwenjun
force-pushed
the
dev_wenjun_addTableInSchema
branch
from
bff7686
to
bbaf7bc
Compare
ruanwenjun
force-pushed
the
dev_wenjun_addTableInSchema
branch
from
bbaf7bc
to
15c62a3
Compare
Hisoka-X
reviewed
Oct 17, 2023
Hisoka-X
approved these changes
Oct 17, 2023
ruanwenjun
force-pushed
the
dev_wenjun_addTableInSchema
branch
from
1445ba0
to
156cc33
Compare
ic4y
approved these changes
Oct 17, 2023
ruanwenjun
added a commit
to ruanwenjun/incubator-seatunnel
that referenced
this pull request
Nov 6, 2023
(cherry picked from commit 652921f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Right now, the CatalogTable generated by config.schema will miss TableIdentifier.
The catalogName can be parsed by connectorName, but the tableIdentifier cannot be configured, this pr will add table/database/comment option in schema, this will used to generate CatalogTable.
Does this PR introduce any user-facing change?
Yes, but this options is not must.
How was this patch tested?
Test by e2e case.
Check list
New License Guide
release-note.