[feature][Transform] Transform supports multi-table scenarios #5646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/execution/ExecutionPlanGenerator.java
4 tasks
|
check ci error |
Hisoka-X
requested changes
Dec 1, 2023
Comment on lines
+47
to
+61
| inputCatalogTables.forEach( | ||
| inputCatalogTable -> { | ||
| String tableId = inputCatalogTable.getTableId().toTablePath().toString(); | ||
| transformMap.put(tableId, buildTransform(inputCatalogTable, config)); | ||
| }); | ||
|
|
||
| this.outputCatalogTables = | ||
| inputCatalogTables.stream() | ||
| .map( | ||
| inputCatalogTable -> { | ||
| String tableName = | ||
| inputCatalogTable.getTableId().toTablePath().toString(); | ||
| return transformMap.get(tableName).getProducedCatalogTable(); | ||
| }) | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
This processing method contains serious potential problems. If there are 10 tables in the upstream, but only one of the tables is need be transformed, the job will report an error because the transform of the remaining 9 tables cannot be constructed normally, there is no corresponding configuration, and it stands to reason that the transforms of the remaining 9 tables should not be constructed, because no modifications have been made at all. We should not foreach the upstream catalogtables, but foreach the user's transform configuration.
hailin0
added
transform-v2
feature
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
1、supports multi-table for transform
2、supports multi-table for assert sink
Does this PR introduce any user-facing change?
Multi-table transfrom is supported. But the original logic is perfectly compatible
How was this patch tested?
add some e2e test
Check list
New License Guide
release-note.