Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Added Table of Contents and FAQs to README #5693

Merged
merged 6 commits into from Oct 27, 2023

Conversation

adarsh-jha-dev
Copy link
Contributor

Purpose of this pull request

This pull request adds a Table of Contents (TOC) and a Frequently Asked Questions (FAQs) section to the README for better user experience and documentation organization.

Does this PR introduce any user-facing change?

No, this PR doesn't introduce any user-facing changes. It's a documentation improvement for better readability and accessibility.

How was this patch tested?

This change was tested by verifying that the documentation renders correctly with the added TOC and FAQs. Manual testing was performed to ensure the TOC links work as expected, providing easy navigation through the document.

Checklist

@adarsh-jha-dev adarsh-jha-dev changed the title [Docs] Add Table of Contents (TOC) and FAQs to README for Improved Documentation Added Table of Contents (TOC) and FAQs to README for Improved Documentation Oct 24, 2023
@adarsh-jha-dev adarsh-jha-dev changed the title Added Table of Contents (TOC) and FAQs to README for Improved Documentation Added Table of Contents and FAQs to README for Improved Documentation Oct 24, 2023
@Hisoka-X Hisoka-X changed the title Added Table of Contents and FAQs to README for Improved Documentation [Improve] Added Table of Contents and FAQs to README for Improved Documentation Oct 24, 2023
@Hisoka-X Hisoka-X changed the title [Improve] Added Table of Contents and FAQs to README for Improved Documentation [Improve] Added Table of Contents and FAQs to README Oct 24, 2023
@Hisoka-X
Copy link
Member

Thanks @adarsh-jha-dev , Could you fix the CI error?

@adarsh-jha-dev
Copy link
Contributor Author

Thanks @adarsh-jha-dev , Could you fix the CI error?

yeah sure, on it

@adarsh-jha-dev
Copy link
Contributor Author

adarsh-jha-dev commented Oct 24, 2023

Thanks @adarsh-jha-dev , Could you fix the CI error?

Hey @Hisoka-X , I have resolved that CI error, you may proceed further.

@Hisoka-X
Copy link
Member

cc @EricJoy2048

@Hisoka-X
Copy link
Member

Could you rebase on dev? We add a new part for SeaTunnel web project.

@adarsh-jha-dev
Copy link
Contributor Author

Could you rebase on dev? We add a new part for SeaTunnel web project.

it is already having the base branch : dev, do i need to change that? If yes, then to which branch?

@Hisoka-X
Copy link
Member

rebase on dev so you can resolve conflict. (Or merge from dev).

@adarsh-jha-dev
Copy link
Contributor Author

adarsh-jha-dev commented Oct 25, 2023

rebase on dev so you can resolve conflict. (Or merge from dev).

Done, you may proceed further

README.md Outdated Show resolved Hide resolved
@Hisoka-X
Copy link
Member

@EricJoy2048 @ic4y @hailin0 @ruanwenjun Are you ok with this change?

EricJoy2048
EricJoy2048 previously approved these changes Oct 26, 2023
README.md Outdated Show resolved Hide resolved
Co-authored-by: Jia Fan <fanjiaeminem@qq.com>
@hailin0 hailin0 merged commit a8f6b18 into apache:dev Oct 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants