Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Engine] Adjust the sleep mode of flink and spark engine to be consistent with zeta #5698

Merged
merged 16 commits into from
Oct 31, 2023
Merged

[Improve][Engine] Adjust the sleep mode of flink and spark engine to be consistent with zeta #5698

merged 16 commits into from
Oct 31, 2023

Conversation

happyboy1024
Copy link
Contributor

Purpose of this pull request

Adjust the sleep mode of flink and spark engine to be consistent with zeta.

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

dengjunjie and others added 13 commits July 3, 2023 17:15
@hailin0
Copy link
Member

hailin0 commented Oct 26, 2023

LGTM

cc @EricJoy2048

EricJoy2048
EricJoy2048 previously approved these changes Oct 30, 2023
View reviewed changes
@happyboy1024
Copy link
Contributor Author

PTAL, I have added some comment about sleep(0). @EricJoy2048 @Hisoka-X

Hisoka-X
Hisoka-X approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @happyboy1024 !

@EricJoy2048 EricJoy2048 merged commit e26006d into apache:dev Oct 31, 2023
5 checks passed
@happyboy1024 happyboy1024 deleted the align-other-engine branch November 29, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved flink reviewed Spark
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@happyboy1024 @hailin0 @EricJoy2048 @Hisoka-X