[Bug][CDC] Fix state recovery error when switching a single table to multiple tables #5784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test case to assert to state of savepoint? |
|
hailin0
force-pushed
the
dev-fix-cdc-restore
branch
from
26376d0
to
9bf9a2d
Compare
hailin0
commented
Nov 3, 2023
| log.info("******************container logs start******************"); | ||
| String containerLogs = container.getServerLogs(); | ||
| log.info(containerLogs); | ||
| Assertions.assertFalse(containerLogs.contains("ERROR")); |
hailin0
force-pushed
the
dev-fix-cdc-restore
branch
3 times, most recently
from
373a5c3
to
27588aa
Compare
hailin0
force-pushed
the
dev-fix-cdc-restore
branch
from
27588aa
to
aafda8d
Compare
Hisoka-X
approved these changes
Nov 7, 2023
EricJoy2048
approved these changes
Nov 7, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
[CDC] Fix state recovery error when switching a single table to multiple tables
Does this PR introduce any user-facing change?
No
How was this patch tested?
https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/MysqlCDCIT.java#L290
Check list
New License Guide
release-note.