Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Rename getCountSql to getExistDataSql #5838

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR rename method getCountSql to getExistDataSql in AbstractJdbcCatalog. Becuase it used to check data exist or not in database, not used to get data count.

Does this PR introduce any user-facing change?

no

How was this patch tested?

exist test.

Check list

Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hailin0 hailin0 merged commit 2233b3a into apache:dev Nov 15, 2023
5 checks passed
@Hisoka-X Hisoka-X deleted the rename-get-count-sql branch November 24, 2023 05:59
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants