Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add unsupported datatype check for all catalog #5890

Merged
merged 3 commits into from
Dec 10, 2023
Merged

[Feature] Add unsupported datatype check for all catalog #5890

merged 3 commits into from
Dec 10, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

After #5864 supported reported unsupported datatype with table name. This PR bring this feature to all Catalog implement class. By the default, any Catalog throw CommonError.convertToSeaTunnelTypeError will record all unsupported data type and table name.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test.

Check list

@Hisoka-X Hisoka-X added the feature New feature label Nov 23, 2023
Carl-Zhou-CN
Carl-Zhou-CN approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Carl-Zhou-CN Carl-Zhou-CN merged commit b979128 into apache:dev Dec 10, 2023
4 checks passed
Carl-Zhou-CN pushed a commit to Carl-Zhou-CN/incubator-seatunnel that referenced this pull request Dec 12, 2023
@Hisoka-X @Carl-Zhou-CN
[Feature] Add unsupported datatype check for all catalog (apache#5890)
0c8ec06 
* [Feature] Add unsupported datatype check for all catalog

* update

* update
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 19, 2023
@Hisoka-X
[Feature] Add unsupported datatype check for all catalog (apache#5890)
0e6d729 
* [Feature] Add unsupported datatype check for all catalog

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Carl-Zhou-CN Carl-Zhou-CN Carl-Zhou-CN approved these changes

Assignees
No one assigned
Labels
approved feature New feature reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hisoka-X @hailin0 @Carl-Zhou-CN