[Bug] Fix Hive-Jdbc use krb5 overwrite kerberosKeytabPath #5891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightzhao
approved these changes
Nov 21, 2023
hailin0
reviewed
Nov 21, 2023
| @@ -76,7 +76,7 @@ public static JdbcConnectionConfig of(ReadonlyConfig config) { | |||
| builder.useKerberos(config.get(JdbcOptions.USE_KERBEROS)); | |||
| builder.kerberosPrincipal(config.get(JdbcOptions.KERBEROS_PRINCIPAL)); | |||
| builder.kerberosKeytabPath(config.get(JdbcOptions.KERBEROS_KEYTAB_PATH)); | |||
| builder.kerberosKeytabPath(config.get(JdbcOptions.KRB5_PATH)); | |||
| builder.krb5Path(config.get(JdbcOptions.KRB5_PATH)); | |||
There was a problem hiding this comment.
Bug fix, current code uses KRB5_PATH to overwrite kerberosKeytabPath this will cause us to use the incorrect Kerberos configuration to login.
Hisoka-X
approved these changes
Nov 23, 2023
hailin0
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.