Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Support using multiple hadoop account #5903

Merged

Conversation

ruanwenjun
Copy link
Member

Purpose of this pull request

Refactor the usage of UserGroupInformation don't use setLoginUser to login in. This method will set a static user in jvm, if and cause we cannot support use multiple hadoop account in one seatunnel server.

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test case

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_supportMultipleHdfsAccount branch 14 times, most recently from b75365f to 31cdfc6 Compare November 27, 2023 12:34
@ruanwenjun
Copy link
Member Author

Please add test case

Add e2e for kerberos, this pr is compatible with the current version.

hailin0
hailin0 previously approved these changes Nov 28, 2023
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_supportMultipleHdfsAccount branch from 31cdfc6 to b648c49 Compare November 30, 2023 03:24
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_supportMultipleHdfsAccount branch 4 times, most recently from 624cee9 to d0fc1d4 Compare November 30, 2023 03:48
@ruanwenjun ruanwenjun marked this pull request as draft November 30, 2023 06:38
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_supportMultipleHdfsAccount branch 3 times, most recently from c7b7746 to 7e0c3ee Compare November 30, 2023 07:50
@ruanwenjun ruanwenjun marked this pull request as ready for review November 30, 2023 07:50
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_supportMultipleHdfsAccount branch 4 times, most recently from 88679e4 to 1001092 Compare December 1, 2023 06:46
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_supportMultipleHdfsAccount branch from 2c664ae to 4b22636 Compare December 7, 2023 12:00
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_supportMultipleHdfsAccount branch from 4b22636 to c47c4b9 Compare December 7, 2023 12:50
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. cc @TyrantLucifer

@ruanwenjun ruanwenjun merged commit d69d88d into apache:dev Dec 17, 2023
7 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_supportMultipleHdfsAccount branch December 17, 2023 11:35
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants