Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Reduce checkpoint completed log #5916

Merged
merged 1 commit into from Nov 27, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR reduce log when start notify checkpoint completed.
Before:

2023-11-24 17:37:25,696 INFO  [.s.e.s.c.CheckpointCoordinator] [seatunnel-coordinator-service-2] - start notify checkpoint 
completed, checkpoint:CompletedCheckpoint(jobId=823342, pipelineId=1, checkpointId=19, 
triggerTimestamp=1700818645675, checkpointType=CHECKPOINT_TYPE, completedTimestamp=1700818645681, 
taskStates={ActionStateKey(name=ActionStateKey - pipeline-1 [Source[0]-
FakeSource])=ActionState(stateKey=ActionStateKey(name=ActionStateKey - pipeline-1 [Source[0]-FakeSource]), 
subtaskStates=[ActionSubtaskState(stateKey=ActionStateKey(name=ActionStateKey - pipeline-1 [Source[0]-FakeSource]), 
index=0)], coordinatorState=ActionSubtaskState(stateKey=ActionStateKey(name=ActionStateKey - pipeline-1 [Source[0]-
FakeSource]), index=-1), parallelism=1), ActionStateKey(name=ActionStateKey - pipeline-1 [Sink[0]-
LocalFile])=ActionState(stateKey=ActionStateKey(name=ActionStateKey - pipeline-1 [Sink[0]-LocalFile]), subtaskStates=
[ActionSubtaskState(stateKey=ActionStateKey(name=ActionStateKey - pipeline-1 [Sink[0]-LocalFile]), index=0)], 
coordinatorState=ActionSubtaskState(stateKey=ActionStateKey(name=ActionStateKey - pipeline-1 [Sink[0]-LocalFile]), 
index=-1), parallelism=1)}, taskStatistics={2=TaskStatistics(jobVertexId=2, subtaskStats=[SubtaskStatistics(subtaskIndex=0, 
ackTimestamp=1700818645680, stateSize=1, subtaskStatus=RUNNING)], subtaskCompleted=[false], 
numAcknowledgedSubtasks=1, latestAckedSubtaskStatistics=null), 4=TaskStatistics(jobVertexId=4, subtaskStats=
[SubtaskStatistics(subtaskIndex=0, ackTimestamp=1700818645681, stateSize=1, subtaskStatus=RUNNING)], 
subtaskCompleted=[false], numAcknowledgedSubtasks=1, latestAckedSubtaskStatistics=null), 
6=TaskStatistics(jobVertexId=6, subtaskStats=[SubtaskStatistics(subtaskIndex=0, ackTimestamp=1700818645680, 
stateSize=0, subtaskStatus=RUNNING)], subtaskCompleted=[false], numAcknowledgedSubtasks=1, 
latestAckedSubtaskStatistics=null), 7=TaskStatistics(jobVertexId=7, subtaskStats=[SubtaskStatistics(subtaskIndex=0, 
ackTimestamp=1700818645681, stateSize=1, subtaskStatus=RUNNING)], subtaskCompleted=[false], 
numAcknowledgedSubtasks=1, latestAckedSubtaskStatistics=null)}, isRestored=false)

After:

2023-11-25 11:23:37,558 INFO  [.s.e.s.c.CheckpointCoordinator] [seatunnel-coordinator-service-2] - start notify checkpoint 
completed, job id: 823342, pipeline id: 1, checkpoint id:40

Does this PR introduce any user-facing change?

no

How was this patch tested?

tested in local

Check list

@EricJoy2048 EricJoy2048 merged commit 9eed623 into apache:dev Nov 27, 2023
4 checks passed
@Hisoka-X Hisoka-X deleted the checkpoint-long-log branch December 1, 2023 08:21
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants