Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][StarRocksSink] add http socket timeout. #5918

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

lightzhao
Copy link
Contributor

@lightzhao lightzhao commented Nov 25, 2023

Purpose of this pull request

add http socket timeout, prevent writes from being blocked all the time.

Does this PR introduce any user-facing change?

No, there is a default configuration, which does not affect.

How was this patch tested?

e2e test.

Check list

Comment on lines 95 to 96
config.getOptional(StarRocksSinkOptions.HTTP_SOCKET_TIMEOUT_MS)
.ifPresent(sinkConfig::setHttpSocketTimeout);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTP_SOCKET_TIMEOUT_MS has default value. So I think you should use config.get(StarRocksSinkOptions.HTTP_SOCKET_TIMEOUT_MS) instead of config.getOptional(StarRocksSinkOptions.HTTP_SOCKET_TIMEOUT_MS). It always return a value used to setHttpSocketTimeout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@Hisoka-X
Copy link
Member

Please add some comment
image

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricJoy2048 EricJoy2048 merged commit febdb26 into apache:dev Nov 27, 2023
7 checks passed
@lightzhao lightzhao deleted the starrocks-sink-timeout branch November 28, 2023 07:59
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants