-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Hive Source/Sink support multiple table #5929
[Feature] Hive Source/Sink support multiple table #5929
Conversation
...-hive/src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/sink/HiveSinkFactory.java
Outdated
Show resolved
Hide resolved
c5b18f7
to
b88017e
Compare
...nnector-hive/src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/sink/HiveSink.java
Show resolved
Hide resolved
...-hive/src/main/java/org/apache/seatunnel/connectors/seatunnel/hive/sink/HiveSinkFactory.java
Outdated
Show resolved
Hide resolved
b88017e
to
a3aa9c8
Compare
```bash | ||
|
||
Hive { | ||
tables_configs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small suggestion is that this is better named using table_list
, maximizing uniform parameter naming There should be a unified specification for the naming of table granularity to better reduce the difficulty of user use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use tables_configs
is consistent with other file connectors. We need to change tables_configs
to table_list
in another PR. I create a new PR for this #6659
Hi, @ruanwenjun Is there any new progress in this PR? |
a3aa9c8
to
24da46a
Compare
24da46a
to
0b9b4c5
Compare
I have resolved the conflicts. |
1f55316
to
35eb5e3
Compare
Please add test case |
557ba63
to
f65d86d
Compare
@@ -25,23 +25,30 @@ env { | |||
|
|||
source { | |||
# This is a example source plugin **only for test and demonstrate the feature source plugin** | |||
FakeSource { | |||
Hive { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert this file and add e2e
f65d86d
to
4ac29af
Compare
4ac29af
to
8d8ced0
Compare
We can add test cases later |
Could you please offer some snapshots to verify it worked? For new hive sink/source has no e2e cases, so I think offer some screenshots would be better. I remember before, the community was formulating relevant regulations. If the merged code can write e2e, e2e should be written. If it cannot be written, relevant information should be provided to explain why it cannot be written. At the same time, some evidence should be provided to prove that this PR is effective and can be used in production. |
Thanks, LGTM |
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.