Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][connector-tdengine] support read bool column from tdengine #6025

Conversation

alextinng
Copy link
Contributor

@alextinng alextinng commented Dec 18, 2023

Purpose of this pull request

supporting read bool column from tdengine.
close #6008

Does this PR introduce any user-facing change?

no

How was this patch tested?

tested with UT.
file path: org/apache/seatunnel/connectors/seatunnel/tdengine/typemapper/TDengineTypeMapperTest.java

Check list

@hailin0
Copy link
Member

hailin0 commented Dec 18, 2023

@alextinng
Copy link
Contributor Author

alextinng commented Dec 19, 2023

@alextinng
Copy link
Contributor Author

alextinng commented Dec 20, 2023

@hailin0 action failed with error "Error: The operation was canceled.", could you please give me a hand?

@Hisoka-X
Copy link
Member

image
please rebase on dev

@alextinng alextinng force-pushed the improvement/support_read_bool_value_from_tdengine branch from 28d4a64 to 44ce2d3 Compare January 22, 2024 02:59
@alextinng
Copy link
Contributor Author

@hailin0 please take a look

Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X
Copy link
Member

Thanks @alextinng !

@Hisoka-X Hisoka-X merged commit af39235 into apache:dev Jan 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] [connector-tdengine] support read bool type data from tdengine
4 participants