-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][JDBC、CDC] Support Short and Byte Type in spliter #6027
Conversation
LGTM |
shall we add test case? |
Please add e2e for this pr. |
It is currently covered by the following tests Lines 381 to 392 in 7c62b61
|
I believe current test case never reach the new code. Because the test case without this PR already passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.