Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][JDBC、CDC] Support Short and Byte Type in spliter #6027

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

ic4y
Copy link
Contributor

@ic4y ic4y commented Dec 18, 2023

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@hailin0
Copy link
Member

hailin0 commented Dec 19, 2023

LGTM
cc @Hisoka-X

@Hisoka-X
Copy link
Member

shall we add test case?

@EricJoy2048 EricJoy2048 added this to the 2.3.4 milestone Jan 8, 2024
@EricJoy2048
Copy link
Member

Please add e2e for this pr.

@ic4y
Copy link
Contributor Author

ic4y commented Jan 18, 2024

Please add e2e for this pr.

It is currently covered by the following tests

// use tinyint column to split
splitArray = getCheckedSplitArray(configMap, table, "c_tinyint", 10);
assertNumSplit(splitArray, "");
// use tinyint_unsigned column to split
splitArray = getCheckedSplitArray(configMap, table, "c_tinyint_unsigned", 10);
configMap.put("partition_column", "c_tinyint_unsigned");
assertNumSplit(splitArray, "");
// use smallint column to split
splitArray = getCheckedSplitArray(configMap, table, "c_smallint", 10);
configMap.put("partition_column", "c_smallint");

@Hisoka-X
Copy link
Member

Please add e2e for this pr.

It is currently covered by the following tests

// use tinyint column to split
splitArray = getCheckedSplitArray(configMap, table, "c_tinyint", 10);
assertNumSplit(splitArray, "");
// use tinyint_unsigned column to split
splitArray = getCheckedSplitArray(configMap, table, "c_tinyint_unsigned", 10);
configMap.put("partition_column", "c_tinyint_unsigned");
assertNumSplit(splitArray, "");
// use smallint column to split
splitArray = getCheckedSplitArray(configMap, table, "c_smallint", 10);
configMap.put("partition_column", "c_smallint");

I believe current test case never reach the new code. Because the test case without this PR already passed.

Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricJoy2048 EricJoy2048 merged commit 6f8d0a5 into apache:dev Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants