[Feature][OssFile Connector] Make Oss implement source factory and sink factory #6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricJoy2048
force-pushed
the
162_oss_support_multiple_table_read
branch
from
d014a2f
to
b066ebd
Compare
| @@ -29,6 +29,9 @@ | |||
|
|
|||
| <properties> | |||
| <hadoop3.version>3.1.4</hadoop3.version> | |||
| <hadoop-aliyun.version>3.1.4</hadoop-aliyun.version> | |||
There was a problem hiding this comment.
Whether it needs to appear in example？
There was a problem hiding this comment.
Whether it needs to appear in example？
Thanks, I will roll back it.
hailin0
reviewed
Dec 24, 2023
| public class LocalFileSinkFactory | ||
| implements TableSinkFactory< | ||
| SeaTunnelRow, FileSinkState, FileCommitInfo, FileAggregatedCommitInfo> { | ||
| public class LocalFileSinkFactory extends BaseMultipleTableFinkSinkFactory { |
There was a problem hiding this comment.
Is this change related to oss?
While adding multi-table support for oss, I found that BaseMultipleTableFinkSinkFactory could be added to make the code cleaner, so I needed to modify the LocalFileSinkFactory implementation
There was a problem hiding this comment.
Is this change related to oss?
While adding multi-table support for oss, I found that BaseMultipleTableFinkSinkFactory could be added to make the code cleaner, so I needed to modify the LocalFileSinkFactory implementation
...nnel-connector-v2-e2e/connector-file-oss-e2e/src/test/resources/excel/fake_to_oss_excel.conf
Outdated
Show resolved
Hide resolved
Co-authored-by: hailin0 <wanghailin@apache.org>
Co-authored-by: hailin0 <wanghailin@apache.org>
…e/src/test/resources/excel/fake_to_oss_excel.conf Co-authored-by: hailin0 <wanghailin@apache.org>
EricJoy2048
force-pushed
the
162_oss_support_multiple_table_read
branch
from
7c5d7de
to
e823425
Compare
alextinng
pushed a commit
to alextinng/seatunnel
that referenced
this pull request
Jan 4, 2024
alextinng
pushed a commit
to alextinng/seatunnel
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
Yes. For specific information, please refer to the changes in the document.
How was this patch tested?
I tested in my local and all test case is success.
Because there is no available OSS environment, I disabled the test cases.
Check list
New License Guide
release-note.