-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connectors-v2-file-ftp] FTP source/sink add ftp connection mode (#6077) #6084
Conversation
Maybe we also need to add test cases to verify that the new parameter |
Yes. Please add test case for this @WilliamTan778 .Thanks |
@CheneyYin @Hisoka-X receive , thanks |
…rameter test class (apache#6077)
@CheneyYin @Hisoka-X This issue requires the deployment of containers that enable NAT. Currently, it is difficult to configure the operation of enabling NAT(Network Address Translation) in FTP containers. After testing several configurations, it is maybe not possible, so only edit config set active_mode_status=true use FTP active mode , No passive mode testing provided , thanks |
public static final Option<Boolean> FTP_ACTIVE_MODE_STATUS = | ||
Options.key("active_mode_status") | ||
.booleanType() | ||
.defaultValue(true) | ||
.withDescription("FTP server mode default active"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am making the necessary modifications , thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://commons.apache.org/proper/commons-net/apidocs/org/apache/commons/net/ftp/FTPClient.html
According to the above content, it can be seen that the Remote mode is server to server (FXP), while our product is in client and server mode, so currently only active is support active_local 、passive_local , thank you very much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created a new pull request and merged the commit. Thank you very much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Fix] [Connectors-v2-file-ftp] FTP source|sink add ftp connection mode (#6077)
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.