[Feature][HbaseSink]support array data. #6100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Dec 28, 2023
| ArrayList<Result> results = new ArrayList<>(); | ||
| ResultScanner scanner = hbaseTable.getScanner(scan); | ||
| for (Result result : scanner) { | ||
| System.out.println("Row Key: " + Bytes.toString(result.getRow())); |
There was a problem hiding this comment.
Suggested change
| System.out.println("Row Key: " + Bytes.toString(result.getRow())); |
Comment on lines
165
to
171
| System.out.println( | ||
| "Column Family: " | ||
| + columnFamily | ||
| + ", Column Name: " | ||
| + columnName | ||
| + ", Value: " | ||
| + value); |
There was a problem hiding this comment.
Suggested change
| System.out.println( | |
| "Column Family: " | |
| + columnFamily | |
| + ", Column Name: " | |
| + columnName | |
| + ", Value: " | |
| + value); |
| } | ||
| results.add(result); | ||
| } | ||
| Assertions.assertEquals(results.size(), 5); |
There was a problem hiding this comment.
Please assert result value. Specially for array value.
Hisoka-X
approved these changes
Jan 2, 2024
hailin0
approved these changes
Jan 2, 2024
alextinng
pushed a commit
to alextinng/seatunnel
that referenced
this pull request
Jan 4, 2024
alextinng
pushed a commit
to alextinng/seatunnel
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
#6052 hbase sink support array data.
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.