Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Zeta] Add restore when commit failed #6101

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Dec 28, 2023

Purpose of this pull request

This PR change the behavior of commit failed. We should retry job as usual.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test

Check list

@Hisoka-X Hisoka-X marked this pull request as ready for review December 28, 2023 11:05
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

hailin0
hailin0 previously approved these changes Jan 2, 2024
@TyrantLucifer
Copy link
Member

What test case can verify it?

@Hisoka-X
Copy link
Member Author

Hisoka-X commented Jan 3, 2024

What test case can verify it?

adding

@TyrantLucifer
Copy link
Member

What test case can verify it?

adding

Could you please offer the details?

@Hisoka-X
Copy link
Member Author

Hisoka-X commented Jan 3, 2024

Could you please offer the details?

I'm adding test case, after it ready, I will push to this PR branch.

@EricJoy2048 EricJoy2048 added this to the 2.3.4 milestone Jan 4, 2024
@Hisoka-X
Copy link
Member Author

Hisoka-X commented Jan 6, 2024

I added new test to cover this. PTAL @TyrantLucifer @hailin0 @TaoZex @EricJoy2048

Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TyrantLucifer TyrantLucifer merged commit 333dc99 into apache:dev Jan 11, 2024
4 checks passed
@Hisoka-X Hisoka-X deleted the restore-when-commit branch January 11, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants