Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix][CDC Base] Fix added columns cannot be parsed after job restore #6118

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

ic4y
Copy link
Contributor

@ic4y ic4y commented Jan 2, 2024

Purpose of this pull request

Fix added columns cannot be parsed after job restore

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@EricJoy2048 EricJoy2048 added this to the 2.3.4 milestone Jan 4, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test case.

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0
Copy link
Member

hailin0 commented Jan 19, 2024

Please rebase dev

hailin0
hailin0 previously approved these changes Jan 19, 2024
@ic4y
Copy link
Contributor Author

ic4y commented Jan 19, 2024

Hisoka-X
Hisoka-X previously approved these changes Jan 19, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

hailin0
hailin0 previously approved these changes Jan 19, 2024
@hailin0 hailin0 dismissed stale reviews from Hisoka-X and themself via 707d367 January 19, 2024 11:19
@hailin0 hailin0 merged commit 0c593a3 into apache:dev Jan 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants