Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][docs] fix k8s dockerfile #6164

Closed
wants to merge 1 commit into from

Conversation

liumengkai
Copy link
Contributor

@liumengkai liumengkai commented Jan 9, 2024

Purpose of this pull request

Fix dockerfile problem,now the dockerfile like this:

...
RUN cd ${SEATUNNEL_HOME}||sh bin/install-plugin.sh ${SEATUNNEL_VERSION}
...

problems:

  1. should use && not ||
  2. In dockerfile cd command can not change the work dirrectory, although we can exec the command,but we are not 'in' the ${SEATUNNEL_HOME} so command can not find plugin_config file

pathc has been tested

Check list

@Hisoka-X
Copy link
Member

Hisoka-X commented Jan 9, 2024

cc @xiamidavid00

@Hisoka-X
Copy link
Member

Could you follow the guide to open your fork repository CI?
image

@liumengkai
Copy link
Contributor Author

Could you follow the guide to open your fork repository CI? image

sure! already done

@liumengkai
Copy link
Contributor Author

liumengkai commented Jan 12, 2024

Hi @Hisoka-X
I have already open my fork repository CI ,It's there anything I can do ?

@hailin0
Copy link
Contributor

hailin0 commented Feb 18, 2024

image

@hailin0
Copy link
Contributor

hailin0 commented Mar 12, 2024

It looks like someone else has fixed this issue #6475

Thanks for your contribution, this PR needs to be closed

@hailin0 hailin0 closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants