Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Connector-V2] Doris stream load use FE instead of BE #6235

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

This PR change doris stream load endpoint from BE to FE. Before this PR, we randomly selected BE, and it would be better to let Doris FE judge the ability to select BE.

Does this PR introduce any user-facing change?

no

How was this patch tested?

exist test.

Check list

this.backends = RestService.getBackendsV2(dorisConfig, log);
String backend = getAvailableBackend();
private void initializeLoad() {
String backend = dorisConfig.getFrontends();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it just returns fe. I wonder what's the purpose here?

Copy link
Member Author

@Hisoka-X Hisoka-X Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the purpose of this PR. Change stream load endpoint from BE to FE.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fe is mainly responsible for doris's query plan. I am worried that if stream load also selects fe, the efficiency of fe will be affected in high concurrency scenarios.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. FE will use http redirect, then data also send from SeaTunnel to BE.
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your response.

Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hailin0 hailin0 merged commit 0a7acdc into apache:dev Jan 19, 2024
11 checks passed
@Hisoka-X Hisoka-X deleted the doris-fe-load branch January 23, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants