Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Oracle-CDC] Fix invalid split key when no primary key #6251

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Jan 18, 2024

Purpose of this pull request

[Oracle-CDC] Fix invalid split key when no primary key

supported no primary-key & custom primary-key
#6209
#6216

Does this PR introduce any user-facing change?

No

How was this patch tested?

https://github.com/apache/seatunnel/pull/6209/files#diff-2ce020b038574b0a89a2903359d5806b57f2f672a144ad7dfdac74d231ac2ee8

Check list

@@ -104,21 +103,4 @@ protected int ObjectCompare(Object obj1, Object obj2) {
return ObjectUtils.compare(obj1, obj2);
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does he need to be removed? I think choosing it in the absence of a primary key is also a valid option.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you select this field as the split column, output the column to the sink.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,In a certain scenario, there can be a bug with the ROWID when a table has existing data before enabling logging, causing the inability to read snapshots.

Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0
Copy link
Member Author

hailin0 commented Jan 19, 2024

ci pssed
image

@EricJoy2048 EricJoy2048 merged commit b83c40a into apache:dev Jan 24, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants