[Improve][CDC] Optimize memory allocation for snapshot split reading #6281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
force-pushed
the
dev-improve-cdc
branch
from
f2f506d
to
2e78048
Compare
Hisoka-X
previously approved these changes
Feb 22, 2024
Hisoka-X
reviewed
Feb 22, 2024
| @@ -90,7 +90,9 @@ public MongodbFetchTaskContext( | |||
|
|
|||
| public void configure(@Nonnull SourceSplitBase sourceSplitBase) { | |||
| final int queueSize = | |||
| sourceSplitBase.isSnapshotSplit() ? Integer.MAX_VALUE : sourceConfig.getBatchSize(); | |||
| sourceSplitBase.isSnapshotSplit() && isExactlyOnce() | |||
There was a problem hiding this comment.
Shall we add some comment for this change?
There was a problem hiding this comment.
fixed
hailin0
force-pushed
the
dev-improve-cdc
branch
from
2e78048
to
ab51538
Compare
Hisoka-X
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
[CDC] Optimize memory allocation for snapshot split reading
Does this PR introduce any user-facing change?
No
How was this patch tested?
this pr already exists
#6209
Check list
New License Guide
release-note.