Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2] Add support for XML file type to various file connectors #6327

Merged
merged 1 commit into from Mar 7, 2024

Conversation

Ivan-gfan
Copy link
Contributor

@Ivan-gfan Ivan-gfan commented Feb 2, 2024

Add support for XML file type to various file connectors such as SFTP, FTP, LocalFile, HdfsFile, and more. #6326

@Hisoka-X
Copy link
Member

Hisoka-X commented Feb 2, 2024

cc @TyrantLucifer

@Ivan-gfan Ivan-gfan changed the title [Feature][Connector-V2] Add support for XML file type to various file connectors [Improve][Connector-V2] Add support for XML file type to various file connectors Feb 4, 2024
@Ivan-gfan Ivan-gfan changed the title [Improve][Connector-V2] Add support for XML file type to various file connectors [Feature][Connector-V2] Add support for XML file type to various file connectors Feb 4, 2024
@@ -0,0 +1,24 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file needed? You can first create xml through sink and then read xml through source

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, I was using this file for source, but later I found out that I could generate it using fake source, and then read it again. I did not delete the file.

Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liugddx liugddx merged commit ec533ec into apache:dev Mar 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants