Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Fix DEFAULT TABLE problem #6352

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

EricJoy2048
Copy link
Member

@EricJoy2048 EricJoy2048 commented Feb 19, 2024

Purpose of this pull request

  1. Add some log
  2. When there is no table_path or database config on the source side, will use default as the database in tableschema.

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@EricJoy2048 EricJoy2048 force-pushed the apache_240219_doris_type_converter branch 2 times, most recently from 0ef9299 to 3b954a9 Compare February 19, 2024 02:39
@hailin0
Copy link
Contributor

hailin0 commented Mar 11, 2024

image

@hailin0
Copy link
Contributor

hailin0 commented Mar 11, 2024

Shall we add test case?

@EricJoy2048
Copy link
Member Author

Shall we add test case?

I do not know how to test this case, only from the log can know the code right.

@EricJoy2048 EricJoy2048 force-pushed the apache_240219_doris_type_converter branch from 3b954a9 to 78666c6 Compare March 27, 2024 06:44
@EricJoy2048 EricJoy2048 force-pushed the apache_240219_doris_type_converter branch from 78666c6 to 136f829 Compare March 27, 2024 06:52
@EricJoy2048 EricJoy2048 force-pushed the apache_240219_doris_type_converter branch from c26a857 to d01d7c1 Compare March 29, 2024 02:26
@EricJoy2048 EricJoy2048 reopened this Mar 29, 2024
…alog/CatalogTableUtil.java

Co-authored-by: Jia Fan <fanjiaeminem@qq.com>
@hailin0 hailin0 merged commit cdb1856 into apache:dev Apr 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants