[Improve][Zeta] Add classloader cache mode to fix metaspace leak #6355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
changed the title
Hisoka-X
commented
Feb 19, 2024
Comment on lines
+53
to
+66
| public void testFakeSourceToInMemorySink() throws IOException, InterruptedException { | ||
| LOG.info("test classloader with cache mode: {}", cacheMode()); | ||
| for (int i = 0; i < 10; i++) { | ||
| // load in memory sink which already leak thread with classloader | ||
| Container.ExecResult execResult = executeJob(server, CONF_FILE); | ||
| Assertions.assertEquals(0, execResult.getExitCode()); | ||
| Assertions.assertTrue(containsDaemonThread()); | ||
| if (cacheMode()) { | ||
| Assertions.assertEquals(3, getClassLoaderCount()); | ||
| } else { | ||
| Assertions.assertEquals(2 + i, getClassLoaderCount()); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The difference of cache mode enable or disable.
|
waiting #6356 |
# Conflicts: # seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java
3 tasks
3 tasks
EricJoy2048
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR try to do two thing.
classloader-cache-modeinseatunnel.yaml. This config is mainly to solve the leakage problem of classloader due to the failure of static thread to be destroyed normally. Through this configuration, all different jobs but using the same jar path will reuse the same classloader to reduce the creation and leakage of static threads.Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test.
Check list
New License Guide
release-note.