Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][RestAPI] always return jobId when call getJobInfoById API #6422

Merged
merged 2 commits into from Mar 6, 2024

Conversation

liunaijie
Copy link
Contributor

Purpose of this pull request

improve the rest api. when get job status by job id. always return the job id to response.

Does this PR introduce any user-facing change?

How was this patch tested?

no need

Check list

@liunaijie
Copy link
Contributor Author

@liugddx PTAL

EricJoy2048
EricJoy2048 previously approved these changes Mar 4, 2024
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a UT case.

@liunaijie
Copy link
Contributor Author

Please add a UT case.

Done, PTAL, thx

Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hailin0 hailin0 merged commit 78cb0de into apache:dev Mar 6, 2024
6 checks passed
@liunaijie liunaijie deleted the restapi-getrunningjob branch March 8, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants