Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Improve][Connector-v2][ElasticsearchSource] Fix behavior when source empty,Support SourceConfig.SOURCE field empty. #6425

Merged
merged 63 commits into from
Apr 29, 2024

Conversation

CosmosNi
Copy link
Contributor

@CosmosNi CosmosNi commented Feb 29, 2024

[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
@CosmosNi
Copy link
Contributor Author

@iture123 @TyrantLucifer @Hisoka-X PTAL,thanks.

@Hisoka-X
Copy link
Member

Hisoka-X commented Mar 6, 2024

I think we should add a e2e test case in

@CosmosNi
Copy link
Contributor Author

@iture123 @TyrantLucifer @Hisoka-X PTAL,thanks.

@Hisoka-X
Copy link
Member

Hi @CosmosNi , thanks for add test! Could you retry the test case after merge from dev?

@CosmosNi
Copy link
Contributor Author

@Hisoka-X I don't understand. Can you show me how to operate it?

@Hisoka-X
Copy link
Member

image
merge code from upstream

@CosmosNi
Copy link
Contributor Author

@Hisoka-X already merge code from upstream,PTAL,thanks.

[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
[Improve][Connector-v2][ElasticsearchSource] Support SourceConfig.SOURCE field empty.
@CosmosNi CosmosNi requested a review from Hisoka-X April 15, 2024 02:24
@CosmosNi
Copy link
Contributor Author

@Hisoka-X i add a label (array_column) to handle es array type,PTAL,thanks.

@CosmosNi
Copy link
Contributor Author

@Hisoka-X @hailin0 @EricJoy2048 PTAL,thanks.

@CosmosNi CosmosNi requested a review from Hisoka-X April 28, 2024 06:24
Hisoka-X
Hisoka-X previously approved these changes Apr 28, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CosmosNi
Copy link
Contributor Author

@Hisoka-X sorry,I accidentally removed label.

@CosmosNi CosmosNi requested a review from Hisoka-X April 28, 2024 07:30
@hailin0 hailin0 merged commit 4e98eb8 into apache:dev Apr 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants