Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix OrcWriteStrategy/ParquetWriteStrategy doesn't login with kerberos #6472

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Mar 8, 2024

Purpose of this pull request

When we use ORC/Parquet with kerberos in file connector or hive connector. we will get kerberos unauthorization exception, this is caused by we didn't login with kerberos in OrcWriteStrategy/ParquetWriteStrategy.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Check list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add test case?

@ruanwenjun
Copy link
Member Author

ruanwenjun commented Mar 11, 2024

Shall we add test case?

Yes, but this case will rely on Kerberos, I didn't find how to add UT.

@liugddx liugddx added this to the 2.3.5 milestone Mar 24, 2024
@hailin0
Copy link
Contributor

hailin0 commented Apr 8, 2024

Shall we add test case?

Yes, but this case will rely on Kerberos, I didn't find how to add UT.

It's okay, we can create an issue and complete it in the future to add test cases

@ruanwenjun
Copy link
Member Author

Shall we add test case?

Yes, but this case will rely on Kerberos, I didn't find how to add UT.

It's okay, we can create an issue and complete it in the future to add test cases

I create issue #6664 for this.

@hailin0
Copy link
Contributor

hailin0 commented Apr 8, 2024

link paimon sink kerberos

Copy link
Contributor

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit 24441c8 into apache:dev Apr 8, 2024
4 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixORC branch April 8, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants