-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature][connector-v2] add xugudb connector #6561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Please add CI trigger in https://github.com/apache/seatunnel/blob/dev/.github/workflows/backend.yml#L985 and rerun CI.
case XUGU_VARCHAR: | ||
case XUGU_VARCHAR2: | ||
builder.dataType(BasicType.STRING_TYPE); | ||
builder.columnLength(typeDefine.getLength()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this length is char length or byte length ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is char length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because multi-byte characters are handled differently in various databases, the byte length is uniformly used in seatunnel
use TypeDefineUtils.charTo4ByteLength(your length)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have handled it in XuguTypeMapper
@@ -0,0 +1,48 @@ | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename jdbc_xugu_source_and_upset_sink.conf
to jdbc_xugu_source_and_upsert_sink.conf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
|
||
@Slf4j | ||
@AutoService(TypeConverter.class) | ||
public class XuguTypeConverter implements TypeConverter<BasicTypeDefine> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
@Slf4j | ||
@AutoService(TypeConverter.class) | ||
public class XuguTypeConverter implements TypeConverter<BasicTypeDefine> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
null, | ||
null, | ||
null, | ||
null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool field is null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes,The Boolean data type has three states: true, false, and unknown. Field values can be true, false, null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.