[Fix][Connector-V2] Fix doris sink can not be closed when stream load not read any data #6570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not read any data
Hisoka-X
commented
Mar 25, 2024
| if (loadException != null) { | ||
| throw new RuntimeException("error while loading data.", loadException); | ||
| } else { | ||
| executorThread = Thread.currentThread(); |
There was a problem hiding this comment.
Before this PR, the executorThread value not right. So that stream load check error thread can not interupt write thread normally.
EricJoy2048
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR fix doris stream load thread not read any data cause writer can not write data into buffer. Finally writer can not check exception because the thread stucked.
Does this PR introduce any user-facing change?
no
How was this patch tested?
tested in local. hard to add test case.
Check list
New License Guide
release-note.