Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc][Improve] Support chinese for sinks #6663

Merged
merged 16 commits into from
Apr 30, 2024
Merged

Conversation

corgy-w
Copy link
Contributor

@corgy-w corgy-w commented Apr 8, 2024

Purpose of this pull request

Translate multiple sink doc files

Does this PR introduce any user-facing change?

no

How was this patch tested?

mvn spotless:apply

Check list

@corgy-w corgy-w mentioned this pull request Apr 8, 2024
3 tasks
@corgy-w
Copy link
Contributor Author

corgy-w commented Apr 8, 2024

@EricJoy2048 @zhilinli123 @Hisoka-X Sorry, due to my inexperience, the PR I originally submitted was contaminated by me, so I closed the previous PR, please help me and take a look at it. The previous review has been changed and the translation of common-options.md has been completed. TKS!! :-)

@zhilinli123
Copy link
Contributor

thanks ping. If you can, please translate Todo first, and then we can review it together for better results

@corgy-w
Copy link
Contributor Author

corgy-w commented Apr 11, 2024

@zhilinli123 @EricJoy2048 E I have completed PR self-review, please check , if there is any problem, I will fix it immediately. Tks!

Copy link
Contributor

@zhilinli123 zhilinli123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thanks contribution,PTAL: @hailin0 @EricJoy2048

@corgy-w
Copy link
Contributor Author

corgy-w commented Apr 19, 2024

Is there any pending point in this pr ?PTAL: @hailin0 @EricJoy2048 tks1

docs/zh/connector-v2/formats/ogg-json.md Outdated Show resolved Hide resolved
docs/zh/connector-v2/formats/ogg-json.md Outdated Show resolved Hide resolved
docs/zh/connector-v2/sink/Elasticsearch.md Outdated Show resolved Hide resolved
docs/zh/connector-v2/sink/Kafka.md Outdated Show resolved Hide resolved
docs/zh/connector-v2/sink/Kafka.md Outdated Show resolved Hide resolved
docs/zh/connector-v2/sink/Kafka.md Outdated Show resolved Hide resolved
@corgy-w
Copy link
Contributor Author

corgy-w commented Apr 19, 2024

@EricJoy2048 Sorry causing you to check so many problems again, they all be complete , TKS!

@corgy-w
Copy link
Contributor Author

corgy-w commented Apr 25, 2024

@EricJoy2048 Sorry causing you to check so many problems again, they all be complete , TKS!

@EricJoy2048 hi If there is still a problem, I will fix the first time.

Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@hailin0 hailin0 merged commit 7b4e072 into apache:dev Apr 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants