Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix][Connector-v2] Fix the sql statement error of create table for doris and starrocks #6679

Merged
merged 6 commits into from
Apr 16, 2024
Merged

[Fix][Connector-v2] Fix the sql statement error of create table for doris and starrocks #6679

merged 6 commits into from
Apr 16, 2024

Conversation

dailai
Copy link
Contributor

@dailai dailai commented Apr 10, 2024 •
edited

Purpose of this pull request

Fix the sql statement error caused by the source table having no primary key or unique key for doris and startrocks. Link #6646

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@dailai dailai force-pushed the fix-doris-create-table-sqlerror branch from 1fca5c5 to 02ddab4 Compare April 10, 2024 08:46
@hailin0 hailin0 requested a review from Hisoka-X April 10, 2024 11:30
Hisoka-X
Hisoka-X reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dailai !

...nnector-doris/src/main/java/org/apache/seatunnel/connectors/doris/util/DorisCatalogUtil.java Outdated Show resolved Hide resolved
...nnector-doris/src/main/java/org/apache/seatunnel/connectors/doris/util/DorisCatalogUtil.java Outdated Show resolved Hide resolved
...nnector-doris/src/main/java/org/apache/seatunnel/connectors/doris/util/DorisCatalogUtil.java Outdated Show resolved Hide resolved
...nnector-doris/src/main/java/org/apache/seatunnel/connectors/doris/util/DorisCatalogUtil.java Outdated Show resolved Hide resolved
...-doris/src/test/java/org/apache/seatunnel/connectors/doris/catalog/DorisCreateTableTest.java Outdated Show resolved Hide resolved
...tor-doris/src/test/java/org/apache/seatunnel/connectors/doris/catalog/PreviewActionTest.java Outdated Show resolved Hide resolved
@Hisoka-X
Copy link
Member

Could you check the starrocks connector too? Thanks

@dailai
Copy link
Contributor Author

dailai commented Apr 11, 2024

Could you check the starrocks connector too? Thanks

OK

@dailai
[Fix][Connector-v2] Fix the sql statement error caused by the source …
5d8dd0b 
…table having no primary key or unique key for doris
@dailai dailai force-pushed the fix-doris-create-table-sqlerror branch from 02ddab4 to 5d8dd0b Compare April 11, 2024 01:38
@dailai dailai changed the title [Fix][Connector-v2] Fix the sql statement error of create table for doris [Fix][Connector-v2] Fix the sql statement error of create table for doris and startrocks Apr 11, 2024
@dailai dailai changed the title [Fix][Connector-v2] Fix the sql statement error of create table for doris and startrocks [Fix][Connector-v2] Fix the sql statement error of create table for doris and starrocks Apr 11, 2024
@dailai dailai requested a review from Hisoka-X April 11, 2024 01:49
@dailai dailai force-pushed the fix-doris-create-table-sqlerror branch from c70bbde to 2ca65f8 Compare April 12, 2024 07:15
@dailai dailai requested a review from Hisoka-X April 12, 2024 07:16
@dailai dailai requested a review from Hisoka-X April 12, 2024 08:25
Hisoka-X
Hisoka-X reviewed Apr 12, 2024
View reviewed changes
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SaveModePlaceHolderEnum.java Outdated Show resolved Hide resolved
...-doris/src/test/java/org/apache/seatunnel/connectors/doris/catalog/DorisCreateTableTest.java Outdated Show resolved Hide resolved
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SaveModePlaceHolderEnum.java Outdated Show resolved Hide resolved
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SaveModePlaceHolderEnum.java Outdated Show resolved Hide resolved
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SaveModePlaceHolderEnum.java Outdated Show resolved Hide resolved
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SaveModePlaceHolderEnum.java Outdated Show resolved Hide resolved
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/sql/template/SqlTemplate.java Outdated Show resolved Hide resolved
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SaveModePlaceHolderEnum.java Outdated Show resolved Hide resolved
@Hisoka-X Hisoka-X linked an issue Apr 12, 2024 that may be closed by this pull request
[Bug] [Doris] sync from mysql to doris create table error #6646
Closed
3 tasks
@dailai dailai closed this Apr 14, 2024
@dailai dailai deleted the fix-doris-create-table-sqlerror branch April 15, 2024 00:33
@dailai dailai restored the fix-doris-create-table-sqlerror branch April 15, 2024 00:52
@dailai dailai reopened this Apr 15, 2024
@dailai dailai requested a review from Hisoka-X April 15, 2024 01:23
Hisoka-X
Hisoka-X reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just use common error to throw key message.

seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonErrorCode.java Outdated Show resolved Hide resolved
seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonError.java Outdated Show resolved Hide resolved
...src/main/java/org/apache/seatunnel/connectors/seatunnel/common/sql/template/SqlTemplate.java Outdated Show resolved Hide resolved
@dailai
Copy link
Contributor Author

dailai commented Apr 15, 2024

We can just use common error to throw key message.

I see it. It's done

@dailai dailai requested a review from Hisoka-X April 15, 2024 09:24
Hisoka-X
Hisoka-X previously approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passed. Thanks @dailai !

@EricJoy2048
Copy link
Member

Just a record: #6354 I add rowtype_dup_key for Doris duplicate table Source sync to Doris duplicate table Sink. After this pr merge, I will change code.

@hailin0 hailin0 merged commit 88263cd into apache:dev Apr 16, 2024
5 checks passed
@dailai dailai deleted the fix-doris-create-table-sqlerror branch April 17, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved bugfix doris-connector reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [Doris] sync from mysql to doris create table error
4 participants
@dailai @Hisoka-X @EricJoy2048 @hailin0