Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Transform] Remove can't find field exception #6691

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

xiaochen-zhou
Copy link
Contributor

Purpose of this pull request

In the FilterFieldTransform, we don't need to use try{} catch to obtain the canNotFoundFields collection, and we can remove the redundant cannotFindInputFieldError logic in the FilterFieldTransform#transformTableSchema().

Does this PR introduce any user-facing change?
no

How was this patch tested?
exist tests.

How was this patch tested?

Check list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @xiaochen-zhou

@hailin0 hailin0 merged commit ffae2f7 into apache:dev Apr 12, 2024
4 checks passed
lostinwind added a commit to lostinwind/dataGovernance that referenced this pull request Apr 15, 2024
@xiaochen-zhou xiaochen-zhou deleted the filter_transform_2 branch May 3, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants