[Feature][Connector-V2] Iceberg-sink supports writing data to branches #6697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoZex
reviewed
Apr 12, 2024
| "sh", "-c", "cd " + CATALOG_DIR + " && tar -zxvf " + NAMESPACE_TAR); | ||
| try { | ||
| Process process = processBuilder.start(); | ||
| // 等待命令执行完成 |
| fileScanTask -> { | ||
| try { | ||
| DataFile file = fileScanTask.file(); | ||
| // 构建文件的输入流 |
sunxiaojian
force-pushed
the
icebergsink-support-write-branch
branch
from
497f5b4
to
16fed67
Compare
|
@hailin0 PTAL |
hailin0
reviewed
Apr 12, 2024
| }; | ||
|
|
||
| @TestTemplate | ||
| public void testInsertAndCheckDataE2e(TestContainer container) |
There was a problem hiding this comment.
How to validate iceberg.table.commit-branch="commit-branch"
There was a problem hiding this comment.
How to validate
iceberg.table.commit-branch="commit-branch"
'loadDataFromIcebergTableBranch()' uses 'table.newScan().useRef(commitBranch)' to specify that data should be read from a branch.
sunxiaojian
force-pushed
the
icebergsink-support-write-branch
branch
2 times, most recently
from
c68c01c
to
f859c2d
Compare
|
@hailin0 PTAL |
|
please check ci error or retry |
sunxiaojian
force-pushed
the
icebergsink-support-write-branch
branch
2 times, most recently
from
1474a4a
to
0ef8ab9
Compare
@hailin0 done |
hailin0
reviewed
Apr 18, 2024
| @@ -109,13 +109,20 @@ public class SinkConfig extends CommonConfig { | |||
| .defaultValue(DataSaveMode.APPEND_DATA) | |||
| .withDescription("data save mode"); | |||
|
|
|||
| public static final Option<String> TABLES_DEFAULT_COMMIT_BRANCH = | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
sunxiaojian
force-pushed
the
icebergsink-support-write-branch
branch
from
5e55397
to
4e8fa8e
Compare
hailin0
reviewed
Apr 19, 2024
| } | ||
| } | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
| log.error("Extract files failed with exit code " + exitCode); | ||
| } | ||
| } catch (IOException | InterruptedException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
add to log message
@hailin0 done
hailin0
approved these changes
Apr 21, 2024
EricJoy2048
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
closed #6686
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.