Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc][Improve] Intro the multi-line text feature in document #6713

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

nianhua99
Copy link
Contributor

Purpose of this pull request

#6682

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

next-generation high-performance,
distributed, massive data integration tool.
"""
```
Copy link
Member

@Hisoka-X Hisoka-X Apr 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about add this case too?

sql = """ select * from "table" """

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, multiline text is indeed common in long SQL queries. I will add this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about add this case too?

sql = """ select * from "table" """

done

@nianhua99 nianhua99 force-pushed the doc_add-multiline-introduction branch from f654519 to 267f9ca Compare April 16, 2024 12:10
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @nianhua99

@hailin0 hailin0 merged commit 2811bfe into apache:dev Apr 16, 2024
7 checks passed
@nianhua99 nianhua99 deleted the doc_add-multiline-introduction branch April 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants