Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] remove useless interface #6746

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

Remove useless interface for IncrementalSource.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existed test cases.

Check list

@hailin0
Copy link
Contributor

hailin0 commented Apr 23, 2024

link
#5100

@TyrantLucifer TyrantLucifer reopened this Apr 24, 2024
@TyrantLucifer TyrantLucifer force-pushed the remove-useless-interface branch 2 times, most recently from 8a8ed57 to ac235ce Compare April 24, 2024 14:03
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit 3c1aeb3 into apache:dev Apr 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants