Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should add ruff-pre-commit a pre-commit hook for Ruff for Python linting and formatting #1367

Closed
jbampton opened this issue Apr 25, 2024 · 1 comment · Fixed by #1368
Closed

Comments

@jbampton
Copy link
Member

jbampton commented Apr 25, 2024

Expected behavior

We should have standardized and well formatted Python code with the correct syntax.

We should add Ruff with pre-commit.

"Ruff supports over 800 lint rules, many of which are inspired by popular tools like Flake8, isort, pyupgrade, and others. Regardless of the rule's origin, Ruff re-implements every rule in Rust as a first-party feature."

https://astral.sh/

https://github.com/astral-sh/ruff-pre-commit

https://github.com/astral-sh/ruff

Actual behavior

We have no coding standards for Python code.

Steps to reproduce the problem

Settings

Sedona version = master

Apache Spark version = ?

Apache Flink version = ?

API type = Scala, Java, Python?

Scala version = 2.11, 2.12, 2.13?

JRE version = 1.8, 1.11?

Python version = ?

Environment = Standalone, AWS EC2, EMR, Azure, Databricks?

@jbampton
Copy link
Member Author

I am now working on this. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant