[SEDONA-544] Add ruff-pre-commit for Python linting
#1368
Merged
+82
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/astral-sh/ruff-pre-commit Currently just running Ruff's linter. Used the default Ruff config file and just added code entries to the `ignore` array.
jiayuasu
approved these changes
Apr 26, 2024
jiayuasu
pushed a commit
that referenced
this pull request
Apr 28, 2024
https://github.com/astral-sh/ruff-pre-commit Currently just running Ruff's linter. Used the default Ruff config file and just added code entries to the `ignore` array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/astral-sh/ruff-pre-commit
Currently just running Ruff's linter.
Used the default Ruff config file and just added code entries to the
ignorearray.Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
fixes #1367
Just getting setup with a basic config file in this PR.
In future we can decide more on formatting and on checking for more "codes".
By having the ruff check we stop regressions in Python syntax and formatting.
https://docs.astral.sh/ruff/configuration/
How was this patch tested?
Ran
pre-commit run --all-filesDid this PR include necessary documentation updates?