[SEDONA-383] Add RS_Band #1001
Merged
[SEDONA-383] Add RS_Band #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
Sep 6, 2023
common/src/main/java/org/apache/sedona/common/raster/RasterBandAccessors.java
Outdated
Show resolved
Hide resolved
...k/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/InferredExpression.scala
Show resolved
Hide resolved
.../src/main/scala/org/apache/spark/sql/sedona_sql/expressions/raster/RasterBandAccessors.scala
Outdated
Show resolved
Hide resolved
jiayuasu
requested changes
Sep 6, 2023
| @@ -45,6 +52,28 @@ case class RS_SummaryStats(inputExpressions: Seq[Expression]) extends InferredEx | |||
| } | |||
| } | |||
|
|
|||
| case class RS_Band(inputExpressions: Seq[Expression]) extends InferredExpression(RasterBandAccessors.getBand _) with SerdeAware with CodegenFallback { | |||
There was a problem hiding this comment.
No need to add SerdeAware and CodgenFallback here as InferredExpression already has those.
jiayuasu
requested changes
Sep 6, 2023
| double [][] bandData = new double[bandsDistinct.length][height * width]; | ||
| for (int curBand: bandsDistinct) { | ||
| RasterUtils.ensureBand(rasterGeom, curBand); | ||
| bandData[curBand - 1] = MapAlgebra.bandAsArray(rasterGeom, curBand); |
There was a problem hiding this comment.
The code here has a bug. It cannot handle cases such as 3, 3, 3 and will throw index out of bound error
jiayuasu
requested changes
Sep 6, 2023
| @@ -45,6 +52,28 @@ case class RS_SummaryStats(inputExpressions: Seq[Expression]) extends InferredEx | |||
| } | |||
| } | |||
|
|
|||
| case class RS_Band(inputExpressions: Seq[Expression]) extends InferredExpression(RasterBandAccessors.getBand _) { | |||
There was a problem hiding this comment.
Please optimize the imports and remove unnecessary imports.
jiayuasu
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?