Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SEDONA-394] fix RS_Band data type bug #1018

Merged
merged 5 commits into from
Sep 14, 2023
Merged

[SEDONA-394] fix RS_Band data type bug #1018

merged 5 commits into from
Sep 14, 2023

Conversation

furqaankhan
Copy link
Contributor

@furqaankhan furqaankhan commented Sep 13, 2023 •
edited

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  • add perservation of pixel data types of pixel/cell.
  • add tests to check perservation
  • add test for RS_AsPNG using RS_Band
  • add docs for RS_AsPNG using RS_Band

How was this patch tested?

  • passed added tests

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation update.

@furqaankhan furqaankhan marked this pull request as ready for review September 13, 2023 21:04
@furqaankhan furqaankhan marked this pull request as draft September 13, 2023 21:15
@furqaankhan furqaankhan marked this pull request as ready for review September 13, 2023 21:56
@jiayuasu jiayuasu added this to the sedona-1.5.0 milestone Sep 14, 2023
@jiayuasu jiayuasu merged commit 4e2761d into apache:master Sep 14, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiayuasu jiayuasu jiayuasu approved these changes

Assignees
No one assigned
Labels
affect public APIs improvement sedona-common sedona-spark
Projects
None yet
Milestone
sedona-1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@furqaankhan @jiayuasu