Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SEDONA-426] Change raster cloning to be able to include metadata. #1080

Merged
merged 23 commits into from
Nov 17, 2023
Merged

[SEDONA-426] Change raster cloning to be able to include metadata. #1080

merged 23 commits into from
Nov 17, 2023

Conversation

iGN5117
Copy link
Contributor

@iGN5117 iGN5117 commented Nov 9, 2023 •
edited
Loading

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  • Add metadata preservation in raster cloning

How was this patch tested?

  • Passed current tests.

Did this PR include necessary documentation updates?

@iGN5117
Refactor notebooks to include SedonaKepler and Sedona 1.5.0
43a448e 
Refactor examples folder to include correct updated Sedona version
@iGN5117
temp commit changing notebook and binder Pipfile
2f11a38
@iGN5117
Merge branch 'master' of https://github.com/apache/sedona into sedona…
0e55f85 
…_master
@iGN5117
Merge branch 'master' of https://github.com/apache/sedona into sedona…
f5353ba 
…_master

# Conflicts:
#	binder/ApacheSedonaSQL.ipynb
#	binder/ApacheSedonaSQL_SpatialJoin_AirportsPerCountry.ipynb
@iGN5117
temp push adding new RasterUtils
120c177
@iGN5117
Add provision of setting a new noDataVal
ed4e35f
@iGN5117
Make use of new RasterUtils create functions in MapAlgebra()
a2f074a
@iGN5117
revert changes to examples
83ed859
@iGN5117
revert changes to Pipfile
31e0fb2
@iGN5117
Fix nullPointerException when checking for noDataValue
81b09fe
@iGN5117
Add a variable controlling metadata creation in RasterUtils
00acb3d
@iGN5117
Refactor MapAlgebra tests
ffeee5d
@jiayuasu
Copy link
Member

@iGN5117 Do we also need to update other related functions such as copyRasterAndAppendBand and copyRasterAndReplaceBand since they also clone the rasters?

@iGN5117
Copy link
Contributor Author

iGN5117 commented Nov 14, 2023

@iGN5117 Do we also need to update other related functions such as copyRasterAndAppendBand and copyRasterAndReplaceBand since they also clone the rasters?

Yes @jiayuasu I will do that once the new rasterUtils functions are approved, This PR will finally replace all places where rasters are cloned

@iGN5117 iGN5117 changed the title Develop nilesh raster clone bug [SEDONA-426] Nov 16, 2023
@iGN5117 iGN5117 changed the title [SEDONA-426] [SEDONA-426] Change raster cloning to be able to include metadata. Nov 16, 2023
@iGN5117 iGN5117 marked this pull request as ready for review November 16, 2023 05:22
@iGN5117 iGN5117 added java Pull requests that update Java code sedona-common behavior change labels Nov 16, 2023
@jiayuasu jiayuasu added this to the sedona-1.5.1 milestone Nov 17, 2023
@jiayuasu jiayuasu removed the java Pull requests that update Java code label Nov 17, 2023
@jiayuasu jiayuasu merged commit a649720 into apache:master Nov 17, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kontinuation Kontinuation Kontinuation left review comments

@jiayuasu jiayuasu jiayuasu approved these changes

Assignees
No one assigned
Labels
behavior change bug improvement sedona-common
Projects
None yet
Milestone
sedona-1.5.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iGN5117 @jiayuasu @Kontinuation