[SEDONA-466] Add new parameter useGeometryExtent to RS_AsRaster
#1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format: ``` RS_AsRaster(RS_AsRaster(geom: Geometry, raster: Raster, pixelType: String, value: Double, noDataValue: Double, useGeometryExtent: Boolean) ```
|
@duhaode520 Would you please fix the lint issue? Thanks! You can use pre-commit to automatically fix this issue and then commit the change. |
jiayuasu
requested changes
Jan 9, 2024
docs/api/sql/Raster-writer.md
Outdated
| @@ -212,9 +212,13 @@ The newly created DataFrame can be written to disk again but must be under a dif | |||
|
|
|||
| Introduction: Converts a Geometry to a Raster dataset. Defaults to using `1.0` for cell `value` and `null` for `noDataValue` if not provided. Supports all geometry types. | |||
| The `pixelType` argument defines data type of the output raster. This can be one of the following, D (double), F (float), I (integer), S (short), US (unsigned short) or B (byte). | |||
|
|
|||
| The `useGeomeryExtent` argument defines the extent of the resultant raster. When set to true, it corresponds to the extent of geom, and when set to false, it corresponds to the extent of raster. | |||
There was a problem hiding this comment.
Please say the default value of useGeometryExtent is true if not set.
There was a problem hiding this comment.
I have added the description of the default value.
jiayuasu
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
useGeometryExtentparameter to user and RS_AsRaster support 6 parameters now.asRasterfunction with 6 parameters. OldasRasterandasRasterwithRasterExtentfunctions are revised accordingly.How was this patch tested?
Did this PR include necessary documentation updates?