[SEDONA-470] Distinguish between missing or null crs from the result of geoparquet.metadata #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
approved these changes
Jan 22, 2024
jiayuasu
pushed a commit
that referenced
this pull request
Apr 28, 2024
…of geoparquet.metadata (#1211) * geoparquet.metadata should show distinct output for missing crs and null crs. * Apply the patch to Spark 3.4 and Spark 3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
This PR makes geoparquet files with null or missing crs fields show different results when inspecting using geoparquet.metadata file format. Please refer to the JIRA ticket for details.
This is done by adding a postprocessing after parsing the geo metadata using json4s. I've not found any other way yet so I decided to keep it that way.
How was this patch tested?
Add new tests and also tested manually using Apache Spark 3.5.
Did this PR include necessary documentation updates?