[SEDONA-479] Update RS_Normalize #1232
Merged
+27
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furqaankhan
reviewed
Feb 2, 2024
| @@ -2468,7 +2468,7 @@ This function only accepts integer as factor before `v1.5.0`. | |||
|
|
|||
| ### RS_Normalize | |||
|
|
|||
| Introduction: Normalize the value in the array to [0, 255] | |||
| Introduction: Normalize the value in the array to [0, 255]. Uniform arrays are set to 0 after normalization. | |||
There was a problem hiding this comment.
What do you mean by this?
There was a problem hiding this comment.
Arrays with all identical values are set to 0 after normalizing
furqaankhan
approved these changes
Feb 2, 2024
jiayuasu
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
Fixes incorrect behavior of RS_Normalize for certain arrays and handles uniform arrays.
How was this patch tested?
Passes new and existing tests
Did this PR include necessary documentation updates?