[SEDONA-471] Support adding pandas df to SedonaKepler if geometry column is not present #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/strategy/join/JoinQueryDetector.scala # spark/common/src/test/scala/org/apache/sedona/sql/BroadcastIndexJoinSuite.scala # spark/common/src/test/scala/org/apache/sedona/sql/TestBaseScala.scala # spark/common/src/test/scala/org/apache/sedona/sql/predicateJoinTestScala.scala
…rgl" This reverts commit 5352fb9.
… column is not available
jiayuasu
approved these changes
Feb 7, 2024
jiayuasu
pushed a commit
that referenced
this pull request
Apr 28, 2024
…umn is not present (#1233) * Add ST_DWithin * Add documentation for ST_DWithin * Remove unwanted code * removed null check test for ST_DWithin * Fix EOF lint error * Add explanation for ST_DWithin * Remove CRS checking logic in ST_DWithin * Add optimized join support for ST_DWithin * Remove test change to resourceFolder * remove unnecessary cast to double * Add broadcast join test * Add example of ST_DWithin in Optimizer.md * Add useSpheroid version to ST_DWithin | Add optimized join support * remove accidental resourceFolder change * Fix mistake in making useSpheroid optional in ST_DWithin * Fix incorrect test data in test_dataframe_api.py * fix failing test in test_predicate.py * Address PR changes | Move ST_DWithin to DistanceJoin * fix failing test * Remove randomness from sphere test case generation * Refactor documentation of ST_DWithin * revert resourceFolder path * Handle complex boolean expressions in ST_DWithin * add a blanket try catch for ST_DWithin to handle complex boolean expressions * add collect to the python test * replace head() with count() * Add null check for geometry column while adding a df to keplergl * Revert "Add null check for geometry column while adding a df to keplergl" This reverts commit 5352fb9. * Add null check for geometry column while adding df to keplergl * support adding pandas df to sedonaKepler and SedonaPyDeck if geometry column is not available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?