-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-473] Remove ucar from spark-shaded pom #1240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not resolve SEDONA-473, since cdm-core
is introduced by the parent POM, not the shaded POM. Actually the POM published to maven central for spark-shaded is a dependency-reduced POM, which does not have dependencies in compile
scope (See https://repo1.maven.org/maven2/org/apache/sedona/sedona-spark-shaded-3.5_2.12/1.5.1/sedona-spark-shaded-3.5_2.12-1.5.1.pom).
The correct way to resolve this issue is to remove https://github.com/apache/sedona/blob/master/pom.xml#L132-L135 in the parent POM.
This reverts commit 67692a6.
@Kontinuation thanks for checking this PR. I was confused if I would need to keep ucar in the parent pom to support NetCDF functionality, but even removing it makes no difference. |
Now it should be good, but I prefer removing the unused dependency instead of commenting it out. |
Yes ofcourse, the comment was temporary. Removed it completely. |
* remove ucar from pom.xml * Revert "remove ucar from pom.xml" This reverts commit 67692a6. * remove ucar from sedona pom.xml * remove comment for ucar
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject
.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?