[SEDONA-497] Fix incorrect fieldNames property of SpatialRDD read from a directory containing multiple shapefiles #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… containing multiple shapefiles.
jiayuasu
approved these changes
Feb 19, 2024
jiayuasu
pushed a commit
that referenced
this pull request
Apr 28, 2024
…m a directory containing multiple shapefiles (#1243)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
We won't concatenate the schema of all shapefiles when inferring the
fieldNamesproperty of the resulting SpatialRDD. This behavior is strange so I changed it to check if all the shapefiles have consistent schema. If there's any concern regarding this change please let me know.How was this patch tested?
Add new tests for reading multiple shapefiles.
Did this PR include necessary documentation updates?