Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-501] ST_Split maps to wrong Java-call #1252

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

niklas-petersen
Copy link
Contributor

@niklas-petersen niklas-petersen commented Feb 22, 2024

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Map Python ST_Split to Java ST_Split.

How was this patch tested?

I updated unit tests. I could not get the polygon/polygon test data (overlapping_polys) to yield a deterministic result, so I added some test data (multipoint_splitting_line) that is identical to the documentation example: https://sedona.apache.org/1.5.1/api/sql/Function/?h=st_#st_split

FYI: The non-deterministic behaviour on splitting polygons with polygons seem just to be the choice for start/end of the split.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu
Copy link
Member

Thanks for fixing this. This is great. Do you want to create another PR to fix the non-deterministic behavior of splitting polygons?

@jiayuasu jiayuasu merged commit c057528 into apache:master Feb 22, 2024
24 checks passed
@niklas-petersen
Copy link
Contributor Author

Thanks. Yes, I can try take a look 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants